Skip to content

Aggregations and logical restructuring #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Nov 10, 2025
Merged

Aggregations and logical restructuring #1149

merged 16 commits into from
Nov 10, 2025

Conversation

@timfdev
Copy link
Contributor

@timfdev timfdev commented Oct 29, 2025 •
edited
Loading

closes #1044

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 29, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #1149 will not alter performance

Comparing feature/agent-aggregrations (1f97a77) with main (9f6a4e5)

Summary

✅ 13 untouched

@sentry
Copy link

sentry bot commented Oct 29, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 49.79647% with 370 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.67%. Comparing base (9f6a4e5) to head (1f97a77).

Files with missing lines Patch % Lines
orchestrator/search/query/builder.py 29.52% 74 Missing ⚠️
orchestrator/search/agent/tools.py 28.57% 70 Missing ⚠️
orchestrator/search/query/results.py 54.90% 46 Missing ⚠️
orchestrator/search/agent/handlers.py 22.44% 38 Missing ⚠️
orchestrator/search/aggregations/base.py 61.84% 29 Missing ⚠️
orchestrator/search/query/engine.py 35.71% 27 Missing ⚠️
orchestrator/api/api_v1/endpoints/search.py 30.43% 16 Missing ⚠️
orchestrator/cli/search/search_explore.py 30.00% 14 Missing ⚠️
orchestrator/search/query/validation.py 22.22% 14 Missing ⚠️
orchestrator/search/agent/prompts.py 9.09% 10 Missing ⚠️
... and 9 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1149      +/-   ##
==========================================
- Coverage   80.23%   79.67%   -0.56%     
==========================================
  Files         266      272       +6     
  Lines       12850    13191     +341     
  Branches     1257     1295      +38     
==========================================
+ Hits        10310    10510     +200     
- Misses       2260     2403     +143     
+ Partials      280      278       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timfdev timfdev marked this pull request as ready for review November 5, 2025 15:16
@timfdev timfdev mentioned this pull request Nov 6, 2025
Merged
@timfdev timfdev requested a review from pboers1988 November 6, 2025 19:15
pboers1988
pboers1988 approved these changes Nov 10, 2025
View reviewed changes
Copy link
Member

@pboers1988 pboers1988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pboers1988 pboers1988 merged commit 6405bf7 into main Nov 10, 2025
17 of 19 checks passed
@pboers1988 pboers1988 deleted the feature/agent-aggregrations branch November 10, 2025 13:55
@timfdev timfdev mentioned this pull request Nov 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pboers1988 pboers1988 pboers1988 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add counting, aggregating, grouping for query building

3 participants

@timfdev @pboers1988